Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React 18 support #111

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Add React 18 support #111

merged 3 commits into from
Apr 6, 2022

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 6, 2022

Basic support to get people unblocked.

Closes #110.
Closes #109.

@ljharb
Copy link
Member

ljharb commented Apr 6, 2022

Changes look good, but unfortunately CI isn't testing on multiple react versions.

@NMinhNguyen NMinhNguyen self-requested a review April 6, 2022 17:22
@gaearon
Copy link
Collaborator Author

gaearon commented Apr 6, 2022

I've verified all tests pass with 16 except the ones with new APIs.

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 6, 2022

I'm not sure what's up with the CI not running. I also don't have merge rights in this repo. Can I have them pls?

@ljharb
Copy link
Member

ljharb commented Apr 6, 2022

You do already, but the branch protections aren't running, it seems. @NMinhNguyen?

@NMinhNguyen
Copy link
Collaborator

@NMinhNguyen
Copy link
Collaborator

NMinhNguyen commented Apr 6, 2022

@ljharb are you able to follow https://circleci.com/docs/2.0/enable-checks/ to enable GitHub Checks? I don't think I'm an admin, so I can't enable it.

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 6, 2022

I don't have permissions to Organization Settings so I can't follow that guide.

Screenshot 2022-04-06 at 18 39 38

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 6, 2022

The last build passed. I don't think I can fix CI without more permissions but let's get this released as a minor?

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 6, 2022

In the interests of getting this out, I plan to publish from my branch locally. Then when CI is fixed, I'll push a version bump to main.

@NMinhNguyen
Copy link
Collaborator

I propose temporarily disabling status checks if the CircleCI integration isn't fixed in the next, say, 10 minutes. Then we can merge this PR, bump the version on main and npm publish.

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 6, 2022

Published as [email protected]. The change is pretty simple and I'm happy to monitor and fast-follow in case there are any problems.

@NMinhNguyen NMinhNguyen merged commit bb9f556 into master Apr 6, 2022
@NMinhNguyen NMinhNguyen deleted the 18 branch April 6, 2022 17:53
@ljharb
Copy link
Member

ljharb commented Apr 6, 2022

I'll take a look at circle right now; @NMinhNguyen, you are a repo admin, but it might take org ownership.

@ljharb
Copy link
Member

ljharb commented Apr 6, 2022

https://app.circleci.com/projects/project-dashboard/github/enzymejs/ should now be set up; let me know if there's something more i need to do.

@NMinhNguyen
Copy link
Collaborator

@ljharb thanks. I've raised #116 to check whether CI works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 18 support
3 participants