Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of settings is broken #171

Closed
ledoge opened this issue Sep 5, 2022 · 4 comments
Closed

Parsing of settings is broken #171

ledoge opened this issue Sep 5, 2022 · 4 comments
Assignees

Comments

@ledoge
Copy link

ledoge commented Sep 5, 2022

Selecting an entry in the "Settings" dropdown at the top should set the values under the Calibration, Profiling, 3D LUT and Verification tabs accordingly. For example, selecting sRGB should set the tone curve to sRGB under Calibration. Instead, all fields just appear to be set to their default values.

I tracked this down to the code here: https://github.com/eoyilmaz/displaycal-py3/blob/main/DisplayCAL/display_cal.py#L17900 . options_displaycal contains strings, but the parser tries to compare them to byte strings, which is why none of the settings are actually applied.

@p5k369
Copy link
Collaborator

p5k369 commented Sep 11, 2022

Hey @ledoge, take a look at #177. That should fix the problem. Besides the byte-str comparison we also had an error when setting the cfg values. However I think @eoyilmaz should take a closer look at those byte-str to str comparison issue because we switched them to byte-str on purpose but I could not figure out why.

@eoyilmaz
Copy link
Owner

Hey guys, I'm a little busy these days, sorry for being late of answering, Hopefully this week I'll look in to code, btw, thank you @p5k369 you're doing great.

eoyilmaz added a commit that referenced this issue Sep 15, 2022
@p5k369
Copy link
Collaborator

p5k369 commented Sep 15, 2022

This issue was partly fixed in #177 . However further investigation is needed. The chosen setting should affect all tabs.

@p5k369 p5k369 self-assigned this Sep 15, 2022
@p5k369
Copy link
Collaborator

p5k369 commented Sep 21, 2022

With windows10 the tabs are updated according to the setting chosen in the dropdown. However on linux the tabs sometimes are updated but the settings inside the last 3 tabs are not set correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants