Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification measurement report is not adjusting to the simulation profile #276

Closed
3ll3d00d opened this issue Jul 3, 2023 · 4 comments
Closed

Comments

@3ll3d00d
Copy link

3ll3d00d commented Jul 3, 2023

this appears to be a regression vs 3.8.9.3

using these settings

on 3.8.9.3
verification_3893

on develop (same for published version)
verification_develop

produces this report on 3.8

verification_report_3893

but this one on develop

verification_report_develop

the nominal gamma is not adjusted which leads to large reported errors

@3ll3d00d
Copy link
Author

3ll3d00d commented Jul 3, 2023

also note how the output profile field is now always visible on develop

@3ll3d00d
Copy link
Author

3ll3d00d commented Jul 3, 2023

output_profile_ctrl is declared in report.xrc

                <object class="FileBrowseButtonWithHistory" name="output_profile_ctrl">
                  <toolTip>output.profile</toolTip>
                  <hidden>1</hidden>
                </object>

on the 3.8 code, FileBrowseButtonXmlHandler creates the above

after this call

https://github.com/eoyilmaz/displaycal-py3/blob/main/DisplayCAL/xh_filebrowsebutton.py#L45

w.Shown becomes False

on develop, it stays on True

so seems to be a regression somewhere in the displaycal specific wx code?

@3ll3d00d
Copy link
Author

3ll3d00d commented Jul 3, 2023

same problem applies to input_value_clipping_bmp but that gets explicitly hidden during wxReportFrame.mr_update_main_controls

3ll3d00d added a commit to 3ll3d00d/displaycal-py3 that referenced this issue Jul 4, 2023
…f gamma applied to a measurement report & workaround apparent wx regression with honouring hidden when set in xrc document eoyilmaz#276
3ll3d00d added a commit to 3ll3d00d/displaycal-py3 that referenced this issue Jul 4, 2023
…f gamma applied to a measurement report & workaround apparent wx regression with honouring hidden when set in xrc document eoyilmaz#276
@3ll3d00d
Copy link
Author

3ll3d00d commented Jul 4, 2023

fixed proposed in #278

3ll3d00d added a commit to 3ll3d00d/displaycal-py3 that referenced this issue Jul 4, 2023
…f gamma applied to a measurement report & workaround apparent wx regression with honouring hidden when set in xrc document eoyilmaz#276
3ll3d00d added a commit to 3ll3d00d/displaycal-py3 that referenced this issue Jul 4, 2023
…f gamma applied to a measurement report & workaround apparent wx regression with honouring hidden when set in xrc document eoyilmaz#276
p5k369 pushed a commit that referenced this issue Jul 6, 2023
* correct bad string/bytes comparison which was preventing correction of gamma applied to a measurement report 
* workaround apparent wx regression with honouring hidden when set in xrc document #276
@3ll3d00d 3ll3d00d closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant