Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced duplicates removal from a custom sequence of test patches #436

Open
aproce opened this issue Oct 17, 2024 · 2 comments
Open

Forced duplicates removal from a custom sequence of test patches #436

aproce opened this issue Oct 17, 2024 · 2 comments

Comments

@aproce
Copy link

aproce commented Oct 17, 2024

Test.zip
Describe the feature being requested
When a custom sequence of test patches is run through DisplayCAL, it removes any repeating/duplicate patches from the sequence. I wanted to request for an option (or even forced behavior) which allows retaining the repeating/duplicate patches.

There are cases when I would like to embed repeating patches at fixed interval in a test sequence, so as to monitor the instability in the display color response. Due to forced duplicates removal by DisplayCAL, I am unable to do so.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Profiling' tab
  2. For the Testchart, upload any custom sequence that has repeating/duplicate patches. I have uploaded a test sequence that has a repeating grey patch (stimulus 90.9804 %) after every 20 patches.

Expected behavior
The uploaded custom sequence should remain unmolested, and no repeating patches should be removed. At least an option should be there for this behavior/feature.

As per Testing on versions:

  • OS: Windows 11
  • Python Version: 3.10
  • ArgyllCMS Version: 3.2.0
  • DisplayCAL Version: 3.9.14
@eoyilmaz
Copy link
Owner

It is probably caused by DisplayCAL.worker.insert_ti_patches_omitting_RGB_duplicates() in:

def insert_ti_patches_omitting_RGB_duplicates(cgats1, cgats2_path, logfn=print):
)

@aproce
Copy link
Author

aproce commented Oct 17, 2024

Yeah, this is the part of the code that needs to be changed.

Great, you have identified it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants