adding file for genres plots #16
Open
+114
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHOOSEIT
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Je pense comme amélioration on pourrait mettre les emotions = COLORS.keys() (pour pas a avoir a tout sync mais c ok)
Par contre GENRES est-ce qu'on pourrait pas juste faire df_main_genres.columns et on enleve wikipedia_ID comme ca c'est plus flexible si on veut en enlever certaines app.
emotions = df_main_genres.columns.tolist()
emotions.remove("wikipedia_ID")
Note pour le merge: Essayer de mettre le COLORS dans un fichier unique pour tous les merges
|
A sinon peut-etre juste move les plots dans utils ? (Sinon on pourra le faire app le merge mais il faut juste y penser :) ) |
|
Aussi pour les deux graphs plot et genre est-ce que ca serait pas bien de center les titres ? Dans les update layout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.