Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with "expect-from" list #29

Open
ZiluTian opened this issue Oct 6, 2022 · 1 comment
Open

issues with "expect-from" list #29

ZiluTian opened this issue Oct 6, 2022 · 1 comment

Comments

@ZiluTian
Copy link
Collaborator

ZiluTian commented Oct 6, 2022

[expectedWorkerSet = receive_map.getOrElse(workerId, SetInt)](

expectedWorkerSet = receive_map.getOrElse(workerId, Set[Int]())
)

log prints out the content of receive_map and workerId properly, but the look up always returns None. receive_map is an immutable map in Scala, which should also be thread safe. Tried explicit type conversions but the issue persisted. First noticed this issue when running Driver and Machine on different ports. Standalone mode seems fine.

Fix: [temporary] replace send-to and receive-from lists with expectAll branch. Workers send a message to every other worker at the end of each round.

@ZiluTian
Copy link
Collaborator Author

ZiluTian commented Oct 6, 2022

expectAll supports current three-level hierarchy. If we allow workers to dynamically spawn new workers, then it will not work directly out of box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant