Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust for encoding in fdata #206

Closed
achaikou opened this issue Dec 9, 2019 · 1 comment
Closed

Adjust for encoding in fdata #206

achaikou opened this issue Dec 9, 2019 · 1 comment

Comments

@achaikou
Copy link
Contributor

achaikou commented Dec 9, 2019

Encoding is supported for EFLRs, but not always for IFLRs, currently we receive error 'could not allocate string object' when utf-8 is broken. In actual files issue happens by accident when actual fdata is broken.
Existing test test_fdata/test_broken_ut8_ascii.

@ErlendHaa
Copy link
Contributor

This can be cased by either 1) non-utf8 ident in the fdata obname or 2) if records is somehow truncated. 1 is solved as fdata now returns dl::ident, not std::string, while 2 is a particular case of #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants