Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps, freshen code, release new major version. #82

Open
ericelliott opened this issue Jun 20, 2018 · 7 comments
Open

Update deps, freshen code, release new major version. #82

ericelliott opened this issue Jun 20, 2018 · 7 comments

Comments

@ericelliott
Copy link
Owner

No description provided.

@labsvisual
Copy link

I would like to help!

@tjconcept
Copy link
Collaborator

I had a bunch of stuff laying around in branches, so I brought a version up to date here: https://github.com/srcagency/credentials

The code base is pretty much a complete rewrite though :P

@ericelliott
Copy link
Owner Author

ericelliott commented Oct 4, 2018

@tjconcept Complete rewrite is fine, as long as the tests still pass and the objectives are still met. Looks like the issues I had with your changes have been fixed. I'm open to merging your changes here.

@tjconcept
Copy link
Collaborator

as long as the tests still pass

They don't. The interface is different:

  • By default there's no instantiation or even a constructor/closure
  • The configure function returns new bound versions of all functions (factory)
  • Promises, no CBs
  • Requires a much newer Node.js version

@ericelliott
Copy link
Owner Author

ericelliott commented Oct 5, 2018

I assume you've updated the test suite and that all the new tests pass? If so, we could simply push it as a new major version.

We'd need to update the docs and run another security review, but I think it's fine.

@tjconcept
Copy link
Collaborator

I assume you've updated the test suite and that all the new tests pass?

Oh, yes, of course 😛

Feel free to do that.

@ChrisRus
Copy link

Just looking at this. Is the intent that if/when this is released it will be a breaking API change? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants