-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps, freshen code, release new major version. #82
Comments
I would like to help! |
I had a bunch of stuff laying around in branches, so I brought a version up to date here: https://github.com/srcagency/credentials The code base is pretty much a complete rewrite though :P |
@tjconcept Complete rewrite is fine, as long as the tests still pass and the objectives are still met. Looks like the issues I had with your changes have been fixed. I'm open to merging your changes here. |
They don't. The interface is different:
|
I assume you've updated the test suite and that all the new tests pass? If so, we could simply push it as a new major version. We'd need to update the docs and run another security review, but I think it's fine. |
Oh, yes, of course 😛 Feel free to do that. |
Just looking at this. Is the intent that if/when this is released it will be a breaking API change? Thanks. |
No description provided.
The text was updated successfully, but these errors were encountered: