Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErickSkrauch/align_multiline_parameters not working correctly with nullable type hints #3

Closed
manuelkiessling opened this issue Nov 16, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@manuelkiessling
Copy link

Hi @erickskrauch,

thanks for a great project, exactly what I'm looking for.

I think I might have encountered an issue, though.

I'd like to use ErickSkrauch/align_multiline_parameters, but it seems to be irritated when type hints are nullable, as in ?string or ?RequestStack.

This is the change it proposed, for a function declaration that already adheres to the align_multiline_parameters rules:

     public function __construct(
         EntityManagerInterface         $entityManager,
         LoggerInterface                $logger,
-        ?RequestStack                  $requestStack,
+        ?RequestStack                              $requestStack,
         WebDeveloperToolsHelperService $webDeveloperToolsHelperService
@erickskrauch erickskrauch added the bug Something isn't working label Nov 16, 2023
@erickskrauch erickskrauch self-assigned this Nov 16, 2023
@erickskrauch
Copy link
Owner

Thank you for the report. I have fixed this issue and released it with the 1.2.1 tag.

@manuelkiessling
Copy link
Author

Thank you so much @erickskrauch, works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants