forked from Knockout-Contrib/Knockout-Validation
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nuget Package to the latest version #3
Open
Condor2708
wants to merge
248
commits into
ericmbarnard:master
Choose a base branch
from
Knockout-Contrib:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which enables group to retraverse the viewmodel if a change in an observableArray is detected
(currently only working for non observable groupings)
… using the live option) Merge branch 'observableArrays' into observableArrays-destroyed Conflicts: Tests/validation-tests.js
…ary not observable array to avoid to cause the reevaluation of computeds depending on the errors for every added validatable.
…be to all observableArrays.
at the creation of the validation group.
- added Steve to the contributors list since he's a new co-maintainer
Reorder phoneUS validation checks to preserve optional properties if observable is not initialized or null. Add unit tests to other extenders to reflect optional properties for uninitialized or null condition.
Manual Validation fixes
Master -> 2.0
Step validation fails for valid changes under certain conditions, due to floating point rounding errors. For instance, 33.34 * 100 will yield a value very close to 3334, but slightly above it and will never equal 3334 exactly. This somewhat fixes this by making less strict checks (modulus should be within a certain tolerance of zero, and the tolerance could be increased if for some crazy reason someone wanted more precision). This also allows the step parameter to have the 'any' value, which is valid according to the HTML5 spec.
Step validation floating point errors fix
Grouping should be able to traverse object structures that has cyclic references
api.reset: Removed dependency on jQuery
…e is not validatable
validationElement and validationMessage bindings throw if observable is not validatable.
Closes #537
If an async rule returns immediately the validation of the observable becomes inconsistent.
Fix for async rules cannot return immediately. If an async rule returns immediately the validation of the observable becomes inconsistent.
- use Knockout-Validation from CDN - use a more recent version of KnockoutJS and use `textInput` binding Closes #251
- update QUnit to 1.17.1 - update KnockoutJS to 3.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please I need the latest version in Nuget, I know that I can build my package but I think it is better for the community to have the nuget repository updated
Thanks a lot