Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An unnecessary space is being added to the "id" attribute #51

Open
AlonEitan opened this issue Dec 25, 2016 · 0 comments
Open

An unnecessary space is being added to the "id" attribute #51

AlonEitan opened this issue Dec 25, 2016 · 0 comments

Comments

@AlonEitan
Copy link

Take a look at the IFRAME template:
https://github.com/erost/ng-videosharing-embed/blob/master/src/directives/embedvideo.js

template: '<iframe data-ng-attr-id="{{id}} "width="{{width}}" height="{{height}}" data-ng-src="{{trustedVideoSrc}}" allowfullscreen frameborder="0"></iframe>',

Note the data-ng-attr-id="{{id}} " which adds a space (" ") at the end. Should be fixed to:

template: '<iframe data-ng-attr-id="{{id}}" width="{{width}}" height="{{height}}" data-ng-src="{{trustedVideoSrc}}" allowfullscreen frameborder="0"></iframe>',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant