Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagging imrovements #1

Open
errordeveloper opened this issue Aug 21, 2020 · 2 comments
Open

tagging imrovements #1

errordeveloper opened this issue Aug 21, 2020 · 2 comments

Comments

@errordeveloper
Copy link
Owner

errordeveloper commented Aug 21, 2020

Some feedback from @justincormack:

  • multiple git tags should result in multiple images (perhaps this could be an opt-in or opt-out)
    • some option to ignore tags maybe needed
  • -dirty is traditional suffix (currently imagine has -wip, for philosophical reasons, but perhaps that could be user-settable)
  • use git tags for dir-scoped image also
@errordeveloper
Copy link
Owner Author

Non-semver tags should be also supported, but probably as an explicit mode.

@errordeveloper
Copy link
Owner Author

One additional point about multiple tags is that with repos that have multiple go.mod files, there will be per-module tags also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant