Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in laravel 9 #13

Open
kirkbushell opened this issue Aug 11, 2022 · 0 comments
Open

Doesn't work in laravel 9 #13

kirkbushell opened this issue Aug 11, 2022 · 0 comments

Comments

@kirkbushell
Copy link

kirkbushell commented Aug 11, 2022

Despite my best efforts, I cannot get emails rendered with mjml in Laravel 9. If you use the mjml property on the various classes, what L9 does is default to markdown (as the view property isn't set).

This package I think needs a fresh approach for L9 (not sure about earlier versions), effectively deferring to the view renderer to manage the requirements (and just let mail messages set the view as something like email.mjml).

Even though the engine does register the extension, it still doesn't seem to parse the mjml file - in fact, the view engine complains that no support for such engines exist.

I'm gonna give it one more go using mailables, but I find it unlikely it will work (as it uses as a similar system in Laravel).

I Honestly think all this package needs to do, is set a new view rendering engine based on mjml extension and that's it - then all developers need to do is simply do:

$mail->view('myemail.mjml', $data) and you're done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant