From e8f0d63cad6fb1f35c66c32f964ee4f08877f6b7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=94=AF=E7=84=B6?= <weiran.zsd@outlook.com>
Date: Fri, 5 Jan 2024 10:49:34 +0800
Subject: [PATCH] chore: a few review suggestions

---
 .github/workflows/CI.yml                  | 9 ++++-----
 tests/eslint-rule-tester.js               | 4 +---
 tests/lib/rules/no-unpublished-require.js | 2 --
 3 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index fc356db8..6d6257a4 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -31,15 +31,12 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macOS-latest]
-        eslint: [8.x]
+        eslint: [8.x, "9.0.0-alpha.0"]
         node: [18.x, 20.x]
         include:
           - os: ubuntu-latest
             node: "21.x"
             eslint: "8.x"
-          - os: ubuntu-latest
-            node: "20.x"
-            eslint: "9.0.0-alpha.0"
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout
@@ -51,7 +48,9 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
       - name: Install Packages
-        run: npm install
+        run:
+            npm i npm@latest -g # use latest npm
+            npm install
       - name: Install ESLint ${{ matrix.eslint }}
         run: |
           npm install --no-save --force eslint@${{ matrix.eslint }}
diff --git a/tests/eslint-rule-tester.js b/tests/eslint-rule-tester.js
index 32117c60..bd7e8244 100644
--- a/tests/eslint-rule-tester.js
+++ b/tests/eslint-rule-tester.js
@@ -11,9 +11,7 @@ const globals = require("globals")
 // greater than or equal to ESLint v9
 exports.gteEslintV9 = +eslintVersion.split(".")[0] >= 9
 
-exports.FlatRuleTester = exports.gteEslintV9
-    ? RuleTester
-    : unofficialApis.FlatRuleTester
+exports.FlatRuleTester = exports.gteEslintV9 ? RuleTester : FlatRuleTester
 
 // to support the `env:{ es6: true, node: true}` rule-tester (env has been away in flat config.)
 // * enabled by default as it's most commonly used in the package.
diff --git a/tests/lib/rules/no-unpublished-require.js b/tests/lib/rules/no-unpublished-require.js
index 7c746c1e..864cb042 100644
--- a/tests/lib/rules/no-unpublished-require.js
+++ b/tests/lib/rules/no-unpublished-require.js
@@ -5,7 +5,6 @@
 "use strict"
 
 const path = require("path")
-const globals = require("globals")
 const RuleTester = require("#eslint-rule-tester").RuleTester
 const rule = require("../../../lib/rules/no-unpublished-require")
 
@@ -182,7 +181,6 @@ ruleTester.run("no-unpublished-require", rule, {
         {
             filename: fixture("1/test.js"),
             code: "require(`foo${bar}`);",
-            languageOptions: { globals: globals.node },
         },
 
         // Should work fine if the filename is relative.