feat: add onRegExpFlags
to RegExpValidator.Options
and deprecate onFlags
#50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
onFlags
inRegExpValidator.Options
and addsonRegExpFlags
option instead.The current
RegExpValidator.Options
onFlags
has too many arguments because it has as many arguments as the number of flags. (And we know that more flags will be added in the future. e.g. https://github.com/tc39/proposal-regexp-v-flag)This has always been a warning to the ESLint we use.
So instead of giving each flag as multiple arguments, I think it's better to have a single object with the flags information.
However, changing
onFlags
would be a breaking change, so I think it makes sense to leaveonFlags
as a deprecated option and introduce a newonRegExpFlags
. The name ofonRegExpFlags
was named with reference toRegularExpressionFlags
used in ES specifications.https://tc39.es/ecma262/#prod-RegularExpressionFlags