Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: use GitHub Actions #12144

Merged
merged 9 commits into from
Aug 30, 2019
Merged

Chore: use GitHub Actions #12144

merged 9 commits into from
Aug 30, 2019

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Aug 22, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain: Trial GitHub Actions

What changes did you make? (Give an overview)

This PR set up GitHub Actions for CI.

GitHub Actions works on Azure that is the current our CI.

There are some cons:

  • It doesn't provide build badge. (E.g., Azure Pipelines provide Build Status)
  • It doesn't provide the detail of tests. (E.g., Azure Pipelines provide the Tests Tab)
  • It doesn't provide the detail of code coverage. (E.g., Azure Pipelines provide the Code Coverage Tab)

Is there anything you'd like reviewers to focus on?

Do we want to switch CI platform?

@mysticatea mysticatea added build This change relates to ESLint's build process infrastructure Relates to the tools used in the ESLint development process evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 22, 2019
@mysticatea mysticatea changed the title [Trial] Chore: use GitHub Actions Chore: use GitHub Actions Aug 22, 2019
@kaicataldo
Copy link
Member

I'm supportive of switching over to GitHub actions 👍 Seems like we might be able to leverage them for other tasks as well.

@g-plane
Copy link
Member

g-plane commented Aug 23, 2019

I think GitHub Actions provides badges. See an example: https://github.com/yarnpkg/berry/blob/master/README.md

@mysticatea
Copy link
Member Author

@g-plane Thank you! I have added the badge, but it doesn't seem to exist until merged.

@platinumazure
Copy link
Member

Thanks for putting this together, @mysticatea!

Are there any benefits to switching to GitHub Actions at this time? So far, I've only seen cons identified in this issue. 😄

@mysticatea
Copy link
Member Author

I think the pro is that we don't need to depend on external services.

And in the future, I guess that we can aggregate CI and other workflows (commit message validator, release cycle monitor, "needs info" label handler, and auto-closer of issues) into GitHub Actions. If it was realized, probably we can reduce the maintenance cost of infrastructure.

@mysticatea mysticatea added the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Aug 27, 2019
@mysticatea
Copy link
Member Author

TSC Summary

This PR switches our CI to GitHub Actions from Azure Pipelines.

Pros:

  • We don't need to depend on external services for CI.
  • I guess that we can aggregate CI and other workflows (commit message validator, release cycle monitor, "needs info" label handler, and auto-closer of issues) into GitHub Actions. If it was realized, probably we can reduce the maintenance cost of infrastructure.

Cons:

  • It's still beta.
  • It doesn't provide the detail of tests. (E.g., Azure Pipelines provide the Tests Tab)
  • It doesn't provide the detail of code coverage. (E.g., Azure Pipelines provide the Code Coverage Tab)

TSC Question

Should we switch CI?

@mysticatea mysticatea removed the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Aug 30, 2019
@mysticatea
Copy link
Member Author

TSC Resolution: We add GitHub Actions beside with Azure Pipelines, then evaluate it. If GitHub Actions gets stable and we find that it's good enough, we will complete switching. Meeting Notes.

@mysticatea mysticatea added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 30, 2019
@mysticatea
Copy link
Member Author

I have re-added files of Azure Pipelines.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion build This change relates to ESLint's build process infrastructure Relates to the tools used in the ESLint development process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants