-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: use GitHub Actions #12144
Chore: use GitHub Actions #12144
Conversation
I'm supportive of switching over to GitHub actions 👍 Seems like we might be able to leverage them for other tasks as well. |
I think GitHub Actions provides badges. See an example: https://github.com/yarnpkg/berry/blob/master/README.md |
@g-plane Thank you! I have added the badge, but it doesn't seem to exist until merged. |
Thanks for putting this together, @mysticatea! Are there any benefits to switching to GitHub Actions at this time? So far, I've only seen cons identified in this issue. 😄 |
I think the pro is that we don't need to depend on external services. And in the future, I guess that we can aggregate CI and other workflows (commit message validator, release cycle monitor, "needs info" label handler, and auto-closer of issues) into GitHub Actions. If it was realized, probably we can reduce the maintenance cost of infrastructure. |
TSC SummaryThis PR switches our CI to GitHub Actions from Azure Pipelines. Pros:
Cons:
TSC QuestionShould we switch CI? |
TSC Resolution: We add GitHub Actions beside with Azure Pipelines, then evaluate it. If GitHub Actions gets stable and we find that it's good enough, we will complete switching. Meeting Notes. |
I have re-added files of Azure Pipelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What is the purpose of this pull request? (put an "X" next to item)
[X] Other, please explain: Trial GitHub Actions
What changes did you make? (Give an overview)
This PR set up GitHub Actions for CI.
GitHub Actions works on Azure that is the current our CI.
There are some cons:
It doesn't provide build badge. (E.g., Azure Pipelines provide )Is there anything you'd like reviewers to focus on?
Do we want to switch CI platform?