Fix: ensure config files are files (#42)

Currently if a directory name matches a config file it will be treated as a file and then fail later when we try and read it.
eslint · Jul 6, 2021 · ce78027 · ce78027
1 parent 95b1c9b
commit ce78027
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/config-array-factory.js b/lib/config-array-factory.js
@@ -495,7 +495,7 @@ class ConfigArrayFactory {
                 basePath
             );
 
-            if (fs.existsSync(ctx.filePath)) {
+            if (fs.existsSync(ctx.filePath) && fs.statSync(ctx.filePath).isFile()) {
                 let configData;
 
                 try {

diff --git a/tests/lib/config-array-factory.js b/tests/lib/config-array-factory.js
@@ -269,7 +269,8 @@ describe("ConfigArrayFactory", () => {
             files: {
                 ...basicFiles,
                 "invalid-property/.eslintrc.json": "{ \"files\": \"*.js\" }",
-                "package-json-no-config/package.json": "{ \"name\": \"foo\" }"
+                "package-json-no-config/package.json": "{ \"name\": \"foo\" }",
+                "package-json-dir/package.json/something": "{}"
             }
         });
 
@@ -301,6 +302,12 @@ describe("ConfigArrayFactory", () => {
             }, /Unexpected top-level property "files"/u);
         });
 
+        it("should ignore directories that have the same name as a config file,", () => {
+            const configArray = factory.loadInDirectory("package-json-dir");
+
+            assert.strictEqual(configArray.length, 0);
+        });
+
         for (const filePath of Object.keys(basicFiles)) {
             const directoryPath = filePath.split("/")[0];