ci: run tests on Node.js v20 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
node 19 isn’t eol yet and should be kept, since dropping a platform is a breaking change. Probably node 17 applies too. |
|
Yeah. I'll keep b17 and v19. Although support wasn't dropped, only tests on CI. But let's keep it. |
|
If it’s not tested then it’s not supported. |
|
|
snitin315
force-pushed
the
snitin315-patch-1
branch
from
7b8ae09
to
8c8acc6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Remove Node v19 and v17 from matrixIs there anything you'd like reviewers to focus on?