Do not try to cancel NULL thread (causing Segmentation fault) #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmah888
reviewed
Nov 21, 2024
src/iperf_api.c
Outdated
| @@ -4498,6 +4498,7 @@ iperf_new_stream(struct iperf_test *test, int s, int sender) | |||
|
|
|||
| memset(sp, 0, sizeof(struct iperf_stream)); | |||
|
|
|||
| sp->thread_created = 0; | |||
There was a problem hiding this comment.
Technically don't need this line because of the memset() above. It's not wrong to have it here though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:Issues fixed (if any): none
Brief description of code changes (suitable for use as a commit message):
Suggested Bug fix: thread id 0 is not regarded as illegal id (at least in Ubuntu Linux), and
pthread_cancel()crashes (Segmentation fault) when trying to cancel a thread with id 0. That happens if streams creation was successful, but there was a failure before all threads are created. The problem happened to me at work and I can reproduce it in my private PC.The suggested fix is to add an indication
thread_createdper stream to indicate if the thread was created for the stream, and try to cancel the stream's thread only if it was created.