Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new app #2992

Merged
merged 4 commits into from
Sep 1, 2023
Merged

added a new app #2992

merged 4 commits into from
Sep 1, 2023

Conversation

nikomin
Copy link

@nikomin nikomin commented Aug 30, 2023

Nightwatch watches sensor data, records min/max value and shows a graph of historic values. Currently for temp and pressure.

@gfwilliams
Copy link
Member

Looks great, thanks! I notice in the screenshot it has NaN in red and green - should that be there or has the min/max value started as undefined or something like that?

@nikomin
Copy link
Author

nikomin commented Aug 30, 2023

Thanks

The NaNs are the top and bottom of the axes. The screen shot is from the emulator and since it doesn't have the sensors it shows that. I probably should fill it with default values or get a screenshot from the watch since on the device this doesn't happen.

@nikomin
Copy link
Author

nikomin commented Aug 30, 2023

Thanks

The NaNs are the top and bottom of the axes. The screen shot is from the emulator and since it doesn't have the sensors it shows that. I probably should fill it with default values or get a screenshot from the watch since on the device this doesn't happen.

I'm on it

@nikomin
Copy link
Author

nikomin commented Aug 31, 2023

So I did upload the changed screenshots. Do I need to make another pull request for the latest revision?

@gfwilliams
Copy link
Member

No, that looks great, thanks! I'm afraid I don't get notified when a PR changes, only when someone comments - otherwise I'd have merged this right away

@gfwilliams gfwilliams merged commit d792e5c into espruino:master Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants