-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Casio Logo Widget #3013
Casio Logo Widget #3013
Conversation
Nice! Out of interest, how does this look with the light theme? |
Good question. I only tested it with LCD Clock (which overrides the theme with its own) before submitting the PR. Just tested it with Anton Clock and it basically disappears since it's hardcoded to be white. |
Thanks! As @bobrippling says, it wouldn't work - but it's the image itself is 1 bit so Espruino will automatically choose the right theme - all that's needed is to remove setColor (which I have just done) |
@gfwilliams Just tested it with few different themes and clock faces. It doesn't look realistic with the theme colors applied to it. It looks better when it's either plain white on dark themes and plain black on light themes. That way it looks like logos on real Casio watches. So something like this worked perfectly for me: if (g.theme.dark) {
g.setColor(255, 255, 255);
} else {
g.setColor(0, 0, 0);
} Can I make a PR for those changes or would you prefer it to stay in the theme colors? |
Which themes are you trying? In the vast majority of themes, the foreground colour is always black or white, so the effect should be the same? |
Ok, I just put a change in. I've just not seen people using themes like that normally... |
A simple widget that displays Casio logo when clock screen is active.
Looks nice in combination with the LCD Clock / LCD Clock Plus.