Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casio Logo Widget #3013

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Casio Logo Widget #3013

merged 2 commits into from
Sep 13, 2023

Conversation

VitaliiTsilnyk
Copy link

A simple widget that displays Casio logo when clock screen is active.

Looks nice in combination with the LCD Clock / LCD Clock Plus.

@bobrippling
Copy link
Collaborator

Nice! Out of interest, how does this look with the light theme?

@VitaliiTsilnyk
Copy link
Author

Good question. I only tested it with LCD Clock (which overrides the theme with its own) before submitting the PR. Just tested it with Anton Clock and it basically disappears since it's hardcoded to be white.

@gfwilliams
Copy link
Member

Thanks! As @bobrippling says, it wouldn't work - but it's the image itself is 1 bit so Espruino will automatically choose the right theme - all that's needed is to remove setColor (which I have just done)

@gfwilliams gfwilliams merged commit c031d81 into espruino:master Sep 13, 2023
1 check passed
@VitaliiTsilnyk
Copy link
Author

@gfwilliams Just tested it with few different themes and clock faces. It doesn't look realistic with the theme colors applied to it. It looks better when it's either plain white on dark themes and plain black on light themes. That way it looks like logos on real Casio watches.

So something like this worked perfectly for me:

      if (g.theme.dark) {
        g.setColor(255, 255, 255);
      } else {
        g.setColor(0, 0, 0);
      }

Can I make a PR for those changes or would you prefer it to stay in the theme colors?

@gfwilliams
Copy link
Member

Which themes are you trying? In the vast majority of themes, the foreground colour is always black or white, so the effect should be the same?

@VitaliiTsilnyk
Copy link
Author

Just custom themes, with red foreground for example, etc. Making the logo the same color as the other text looks off.
image image

Looks much better when it's white (more like silver in real life) or black.
image image
Looks like an actual logo that's not part of the watch screen.

@gfwilliams
Copy link
Member

Ok, I just put a change in. I've just not seen people using themes like that normally...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants