HRM Widget+ adds bpm digits in lato font, plus some README, icon, screenshot fixes

[hughbarney]

No description provided.

[bobrippling]

Nice, LGTM! Just two little things on intercepting setHRMPower

[bobrippling]

I'm happy to merge (and install on my watch!) if that's ok with you too @thyttan?

[thyttan]

I'm happy to merge (and install on my watch!) if that's ok with you too @thyttan?

I didn't look too closely - if you and @hughbarney are happy that's good enough for me 👍

I'd personally maybe have opted for the id to be widhrtplus to match the user facing name, like we did with runplus/Run+. But doesn't really matter :p

[bobrippling]

I'd personally maybe have opted for the id to be widhrtplus to match the user facing name, like we did with runplus/Run+

Yeah that might help it stand out more, what do you think @hughbarney?

[gfwilliams]

I'd personally maybe have opted for the id to be widhrtplus

Yes, I think this would be best. No other apps use + in the name, and I'd be a bit concerned that it could cause issues trying to store those files on some operating systems?

But otherwise this looks good

[hughbarney]

I have changed id to widhrtplus. I should point out that no files have a + in the name.

I'm rather confused by how to manage edits to a pull request once it has been submitted; I might have broken other changes that Rob did to my pull request above, I have no idea how I would get such changes into my branch to merge them etc.

(@thyttan accidentally edited this comment - sorry!)

[thyttan]

I'm rather confused by how to manage edits to a pull request once it has been submitted; I might have broken other changes that Rob did to my pull request above, I have no idea how I would get such changes into my branch to merge them etc.

I wasn't really sure myself, so I found this:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

So the suggested changes you decide to commit in will be added to the branch you want to merge in with espruino/BangleApps:master, in this case hughbarney/BangleApps:master. Those will now be in your branch here on github, but not sync to your local copy if you cloned the repo to your computer. That should be resolved if you fetch or pull the changes from the remote copy on github (I think).

[bobrippling]

There's no problem in this case, what you've done is spot on imo - a merge (of upstream/master) and extra changes committed followed by a push is a good way to check. If git sees that anything might be overwritten, it'll fail at the push, so that can be used to check nothing's been missed :)

(in this case I only had comments, no changes to your branch, so nothing is lost)

[bobrippling]

Meant to say - I'm happy to merge if everyone else is?

[hughbarney]

I wasn't really sure myself, so I found this: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

Glad it is not just me. I'e going to try and do my next app all through the fork on github - and try and use the 'update fork' button which I could not find, maybe I was not signed into github.

[gfwilliams]

Thanks! Looks good to me! Sorry about the confusion on the naming - I saw HRM Widget + and assumed the app ID was widhrm+ - thanks for making the change anyway, and I think that probably fits better with what we've done in other apps (run/runplus/etc)