Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pomoplus: new setting and minor changes #3019

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

notEvil
Copy link

@notEvil notEvil commented Sep 16, 2023

see https://notevil.github.io/BangleApps/?q=pomoplus

  • adds setting "Show clock"

If set, returns to clock (Bangle.showClock()) after start/resume.

  • minor changes
    • (changed*) buzz pattern of long break
    • added g.clear() and adjusted .clearRect in drawTimerAndMessage
    • replaced g.getWidth() and g.getHeight() with w and h

@bruceblore is this in conflict with your vision for this app?

*nothing changed since atm the last buzz immediately follows the second one

@bruceblore
Copy link
Contributor

No conflict with my vision. I think that's a good feature to have, and people who do not like it can just turn it off. And I appreciate the code quality improvements.

@gfwilliams
Copy link
Member

Looks good to me! Thanks for the link to try it out.

I guess a nice addition at some point might be to try and use the sched library to schedule the timer (rather than boot code?). Having less boot code means app switching is a bit faster :)

@gfwilliams gfwilliams merged commit 92ddfe9 into espruino:master Sep 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants