openhaystack: store battery status in FindMy packet #3566
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also: seemoo-lab/openhaystack#185 https://github.com/MatthewKuKanich/FindMyFlipper/blob/e5a678e33dd17af46bb63050be4c9d10e17f6252/FindMyFlipper/findmy_state.c#L126-L137 From biemster/FindMy#53 Advertising byte: ?xx1rrmrr r: reserved m: maintained x: can be set. x must be: 00: full 01: medium 10: low 11: critical this doesn't seem to correspond with the above links
bobrippling
force-pushed
the
feat/openhaystack-battery
branch
from
15bbc06 to
924f963
Compare
|
This looks cool. I'd be fine with merging it anyway. Interestingly it's nice to have a way to send some data back. For instance if you had a remote letterbox or something it could report battery level as full if there was something in it, or nearly empty if there wasn't. |
|
Yes that would be very cool to repurpose the 4 values as another form of communication - or it'd be interesting to see if "invalid" battery values made it through the network too. I've had this running but my watch hasn't appeared on the network in a while, so can't confirm yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a user to know their device's battery, as well as its location
See also:
seemoo-lab/openhaystack#185
https://github.com/MatthewKuKanich/FindMyFlipper/blob/e5a678e33dd17af46bb63050be4c9d10e17f6252/FindMyFlipper/findmy_state.c#L126-L137
@olivierbarriere let me know what you think - I'll be testing this over the next week or so