Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: v3 discovery url #10373

Closed
gertcuykens opened this issue Jan 6, 2019 · 5 comments
Closed

docs: v3 discovery url #10373

gertcuykens opened this issue Jan 6, 2019 · 5 comments

Comments

@gertcuykens
Copy link

https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/clustering.md#etcd-discovery

curl -X PUT https://myetcd.local/v2/keys/discovery/6c007a14875d53d9bf0ef5a6fc0257c817f0fb83/_config/size -d value=3

Not sure if the doc is deprecated or there is simple no v3 discovery? related to #8209

Incase there is no v3 discovery url can this be mentioned in the doc please

@hexfusion
Copy link
Contributor

Not sure if the doc is deprecated or there is simple no v3 discovery? related to #8209

@gertcuykens the docs are still accurate if you start a cluster for the purpose of discovery this will still work, have you tried it? If this doesn't work please let us know.

Incase there is no v3 discovery url can this be mentioned in the doc please

Would you mind creating PR to this? We want users to know that although v2 discovery API uses v2 store that creating a dedicated cluster for the purpose of discovery would be fine IMO.

https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/clustering.md#etcd-discovery

We are still reviewing options for discovery in v3.

@gertcuykens
Copy link
Author

gertcuykens commented Jan 8, 2019

Ok I will do PR, just wanted to be sure I didn't mis some v3 discovery options. In the end I think we must make sure we can slim down etcd codebase removing deprecated code and have no v2 dependencies to build a v3 only build making it easier to maintain. Don't think we want discovery to be the cause holding a v3 only build back. For me ETCDCTL_API=3 should be more like a compile option then runtime option. Just think of how much it decreases potentially old v2 security bugs you can avoid by just building a v3 only

@hexfusion
Copy link
Contributor

Ok I will do PR, just wanted to be sure I didn't mis some v3 discovery options.

Thanks!

For me ETCDCTL_API=3 should be more like a compile option then runtime option.

I agree and ETCDCTL_API=3 is default for 3.4+.

Just think of how much it decreases potentially old v2 security bugs you can avoid by just building a v3 only build back.

Deprecating v2 store is in the works for 4.0 #9232. But in the meantime feel free to disable v2 if you don't want to worry about it with --enable-v2 flag.

Your points are valid but this will take time to decouple and we of course would love your help :)

@hexfusion
Copy link
Contributor

FTR we do plan on adding the discovery API to v3. This should happen during the 1st quarter and be part of a future release TBD.

@hexfusion hexfusion self-assigned this Jan 18, 2019
@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 7, 2020
@stale stale bot closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants