Uncle blocks are missing in eth_getBlockByHash RPC response

[APshenkin]

Hi there,

Please note that this is an issue tracker reserved for bug reports and feature requests.

For general questions please use discord or the Ethereum stack exchange at https://ethereum.stackexchange.com.

System information

Geth version: 1.11.22
OS & Version: Windows/Linux/OSX Docker
Commit hash : (if develop)

Expected behaviour

eth_getBlockByHash should return uncles in data as array

Actual behaviour

uncles are missing

Steps to reproduce the behaviour

curl --location --request POST 'https://myetcnode.com' \
--header 'Content-Type: application/json' \
--data-raw '{
    "jsonrpc": "2.0",
    "method": "eth_getBlockByHash",
    "params": [
        "0x2733c5587974f120453b556a71bf096199c587b5a530d98d6a4d6a1746ec967b",
        true
    ],
    "id": 83
}'

[APshenkin]

Also eth_getBlockByHash don't return transactions array if it's empty. Seems like some issue with serialization? (it removes empty arrays from response)

[APshenkin]

Seems related to this code.

core-geth/internal/ethapi/api.go

Line 1220 in 73e58be

Uncles []common.Hash `json:"uncles,omitempty"`

omitempty should be removed

[meowsbits]

Yeap, I think you're right on. Will have a PR in today fixing this. Good catch, thank you!