internal/ethapi: don't omit empty txes, uncles from getBlock responses #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should return an empty array when empty. Resolves #332 Date: 2021-03-12 07:47:43-06:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-12 08:54:06-06:00 Signed-off-by: meows <[email protected]>
meowsbits
force-pushed
the
fix-eth-getblock-api-tx-uncles
branch
from
aee6fb5 to
ee4e34a
Compare
Date: 2021-03-12 10:19:07-06:00 Signed-off-by: meows <[email protected]>
|
This is related (in regard to bad marshaling) to #334. That issue opens a can of worms though, so I suggest to move forward this (and it's respective issue) and 334 independently. |
iquidus
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should return an empty array when empty.
Resolves #332
Date: 2021-03-12 07:47:43-06:00
Signed-off-by: meows [email protected]