Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect TypeScript "data" type declaration #55

Closed
nikitaeverywhere opened this issue Aug 26, 2020 · 4 comments
Closed

Incorrect TypeScript "data" type declaration #55

nikitaeverywhere opened this issue Aug 26, 2020 · 4 comments
Labels
Documentation

Comments

@nikitaeverywhere
Copy link

nikitaeverywhere commented Aug 26, 2020 •
edited
Loading

Hello! My TypeScript complains on the very first example you provide in the readme:

image

I guess this type declaration has to be either Object (it has toString already) or { [key: string]: any, toString(): string }.

What do you think? I will be happy to make a PR.

Thanks for great work.
@nikitaeverywhere nikitaeverywhere changed the title Incorrect TypeScript type declaration Incorrect TypeScript "data" type declaration Aug 26, 2020
@Sazzo
Copy link

Sazzo commented Sep 26, 2020

Same here ^

@ethan7g
Copy link
Owner

ethan7g commented Nov 1, 2020

Thanks! A PR would be much appreciated if anyone is interested.

@jdforsythe
Copy link
Contributor

Fixed in #65

@andreasonny83
Copy link

Please, release a new version with the fix

@ethan7g ethan7g closed this as completed Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jdforsythe @nikitaeverywhere @andreasonny83 @ethan7g @Sazzo