From 48bec76f5885098a571f21e545f7bba307972d25 Mon Sep 17 00:00:00 2001 From: John Forrest Date: Thu, 15 Mar 2018 17:09:22 -0500 Subject: [PATCH 1/2] Update operator language - Fixed typo (operator to operators) - Explicitly call out the implementation MUST support multiple operators per owner as implied by the comments - Removed unnecessary throw from the dev instructions on setApprovalForAll --- EIPS/eip-721.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/EIPS/eip-721.md b/EIPS/eip-721.md index 5b67646925a7d7..50e530ccd6056a 100644 --- a/EIPS/eip-721.md +++ b/EIPS/eip-721.md @@ -60,7 +60,8 @@ interface ERC721 /* is ERC165 */ { event Approval(address indexed _owner, address indexed _approved, uint256 _tokenId); /// @dev This emits when an operator is enabled or disabled for an owner. - /// The operator can manage all NFTs of the owner. + /// The operator can manage all NFTs of the owner. The contract MUST allow + /// multiple operators per owner. event ApprovalForAll(address indexed _owner, address indexed _operator, bool _approved); /// @notice Count all NFTs assigned to an owner @@ -123,7 +124,7 @@ interface ERC721 /* is ERC165 */ { /// all of `msg.sender`'s assets. /// @dev Emits the ApprovalForAll event /// @param _operator Address to add to the set of authorized operators. - /// @param _approved True if the operators is approved, false to revoke approval + /// @param _approved True if the operator is approved, false to revoke approval function setApprovalForAll(address _operator, bool _approved) external; /// @notice Get the approved address for a single NFT From 87f1091c0cb2df961fbd8085cc56de8a039b2af6 Mon Sep 17 00:00:00 2001 From: John Forrest Date: Tue, 27 Mar 2018 10:48:17 -0500 Subject: [PATCH 2/2] Moving operator language to function instead of event --- EIPS/eip-721.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/EIPS/eip-721.md b/EIPS/eip-721.md index 50e530ccd6056a..33579a82375963 100644 --- a/EIPS/eip-721.md +++ b/EIPS/eip-721.md @@ -60,8 +60,7 @@ interface ERC721 /* is ERC165 */ { event Approval(address indexed _owner, address indexed _approved, uint256 _tokenId); /// @dev This emits when an operator is enabled or disabled for an owner. - /// The operator can manage all NFTs of the owner. The contract MUST allow - /// multiple operators per owner. + /// The operator can manage all NFTs of the owner. event ApprovalForAll(address indexed _owner, address indexed _operator, bool _approved); /// @notice Count all NFTs assigned to an owner @@ -122,7 +121,8 @@ interface ERC721 /* is ERC165 */ { /// @notice Enable or disable approval for a third party ("operator") to manage /// all of `msg.sender`'s assets. - /// @dev Emits the ApprovalForAll event + /// @dev Emits the ApprovalForAll event. The contract MUST allow + /// multiple operators per owner. /// @param _operator Address to add to the set of authorized operators. /// @param _approved True if the operator is approved, false to revoke approval function setApprovalForAll(address _operator, bool _approved) external;