Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Multi-Namespace Onchain Registry #7406

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

wilsonccccc
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Jul 26, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 26, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Add new EIP: Multi-Namespace Onchain Registry Add EIP: Multi-Namespace Onchain Registry Jul 26, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jul 26, 2023
@github-actions
Copy link

The commit 44695cc (as a parent of ffa9713) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 26, 2023
@wilsonccccc wilsonccccc force-pushed the new_eip2 branch 2 times, most recently from 7b44bc1 to a100313 Compare July 26, 2023 05:53
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 26, 2023
@wilsonccccc wilsonccccc marked this pull request as ready for review July 26, 2023 05:55
@wilsonccccc wilsonccccc requested a review from eth-bot as a code owner July 26, 2023 05:55
EIPS/eip-7406.md Outdated
discussions-to: https://ethereum-magicians.org/t/eip-7406-multi-namespace-onchain-registry/15216
status: Draft
type: Standards Track
category: Core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
category: Core
category: ERC

This is an ERC (application layer)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reviewing, resolved

Copy link
Contributor Author

@wilsonccccc wilsonccccc Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abcoathup Hi Andrew, may I ask for your kind review or any feedback when you have time. Much appreciated. cc @axic, @Pandapip1, @SamWilsn, @xinbenlv

EIPS/eip-7406.md Outdated Show resolved Hide resolved
EIPS/eip-7406.md Show resolved Hide resolved
EIPS/eip-7406.md Outdated Show resolved Hide resolved
wilsonccccc and others added 3 commits August 22, 2023 08:39
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
@wilsonccccc
Copy link
Contributor Author

@SamWilsn Hi Sam, Much appreciated for taking the time to review the diff, all comments are addressed, please review again when you have time. Best

@wilsonccccc wilsonccccc requested a review from SamWilsn August 22, 2023 15:42
@wilsonccccc
Copy link
Contributor Author

@SamWilsn Hi Sam, Happy Friday, just a kind reminder if you can take a quick review of our EIP when you have time? That will be much appreciated. Best

@eth-bot eth-bot enabled auto-merge (squash) September 5, 2023 15:38
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit b5bf61f into ethereum:master Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants