Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BLS_TO_EXECUTION_CHANGE from event stream #283

Closed
potuz opened this issue Dec 21, 2022 · 2 comments
Closed

Remove BLS_TO_EXECUTION_CHANGE from event stream #283

potuz opened this issue Dec 21, 2022 · 2 comments

Comments

@potuz
Copy link

potuz commented Dec 21, 2022

In #248 the BLS_TO_EXECUTION_CHANGE messages were added to the event stream. Given that

  1. the vast majority of validators have BLS withdrawal credentials
  2. There's a strong incentive to submit these messages as soon as possible
  3. There is no current need in clients for such a stream

I want to explore removal of this feature, at least until the expected volume of these changes diminishes.

@mcdee
Copy link
Contributor

mcdee commented Dec 21, 2022

I don't think that there is going to be a particularly high volume of these messages, given that we know they are bounded at under 290,000 and it's unlikely that everyone will be rushing to send these immediately.

The endpoint may be useful for analysis of when these messages are sent and received across the network, as well as picking up on conflicting messages where more than one entity has access to the validator private key.

I'm not going to fight to keep it, but I don't think that volume of messages should be a major concern given that attestation events significantly exceed this number every few minutes.

@rkapka
Copy link
Contributor

rkapka commented May 29, 2023

Now that Capella has happened, I think we can close the issue.

@rkapka rkapka closed this as completed May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@mcdee @potuz @rkapka and others