Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schemas for "pruned" beacon blocks are incorrect #292

Closed
Tracked by #364
ralexstokes opened this issue Jan 26, 2023 · 2 comments
Closed
Tracked by #364

Schemas for "pruned" beacon blocks are incorrect #292

ralexstokes opened this issue Jan 26, 2023 · 2 comments

Comments

@ralexstokes
Copy link
Member

Refer: https://github.com/ethereum/beacon-APIs/blob/master/apis/beacon/blocks/blinded_block.yaml#L34-L39

The schemas have "full" (signed) beacon blocks whereas this endpoint should provide blinded beacon blocks.

AIUI we should update these schemas to the right type -- and taking a look at the other blinded endpoints, I see a similar issue.

@staccDOTsol

This comment was marked as spam.

@Falehfale Falehfale mentioned this issue Sep 28, 2023
Closed
@dapplion
Copy link
Collaborator

dapplion commented Dec 8, 2023

This issue appears fixed.

All blinded_* routes declare the blinded block types for post bellatrix and the full types for pre bellatrix. This is correct, since the pre bellatrix types do not have an execution payload thus full type = blinded type

oneOf:
- $ref: "../../../beacon-node-oapi.yaml#/components/schemas/SignedBeaconBlock"
- $ref: "../../../beacon-node-oapi.yaml#/components/schemas/Altair.SignedBeaconBlock"
- $ref: "../../../beacon-node-oapi.yaml#/components/schemas/Bellatrix.SignedBlindedBeaconBlock"
- $ref: "../../../beacon-node-oapi.yaml#/components/schemas/Capella.SignedBlindedBeaconBlock"
- $ref: "../../../beacon-node-oapi.yaml#/components/schemas/Deneb.SignedBlindedBeaconBlock"

please re-open if I'm missing something

@dapplion dapplion closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants