-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify fork boundary op pool behavior #458
Comments
In Teku we went with returning Electra messages only and ignored the other ones. |
We had a quick discussion on the PR that we don't want mixed attestation arrays. I tend to agree that it might be better to just drop them from the response as I would expect the only reason why they are still in the op pool is that it's not worth it to prune it at fork boundry. |
switched this to filtering in LH i think that makes more sense, thanks for the feedback guys 🙏 |
Not sure if this has already been discussed, but
GET
queries to the op pool around the fork boundary return a list of what could be mixed message types, some pre-electra and some post-electra. It's not clear how this should be handled considering we are addingversion: electra
to the top-level of the JSON, implying the message should be interpreted as containing electra structs.In Lighthouse we're opting to convert all messages to their electra version in electra, but this may be unexpected as it is unspecified.
The text was updated successfully, but these errors were encountered: