From 0885a083ede77020866d09e03329fdbfbc3ff61e Mon Sep 17 00:00:00 2001 From: Paul Harris Date: Fri, 23 Jun 2023 10:29:42 +1000 Subject: [PATCH 1/2] Made eth-consensus-version required on new blocks endpoints When initially adding eth-consensus-version to interfaces it wasn't able to be required due to backwards compatibility issues. Given these interfaces are new, we should set it as a required header. This will simplify the determination of whether we're reading a deneb blockContents or a pre-deneb signed block. Potentially we deprecate the other interface once deneb comes around, but that's up for discussion, and I'm not putting that into this PR, just making this header required for the new interfaces. --- apis/beacon/blocks/blinded_blocks.v2.yaml | 2 +- apis/beacon/blocks/blocks.v2.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apis/beacon/blocks/blinded_blocks.v2.yaml b/apis/beacon/blocks/blinded_blocks.v2.yaml index aa361ba2..ad1e6b3f 100644 --- a/apis/beacon/blocks/blinded_blocks.v2.yaml +++ b/apis/beacon/blocks/blinded_blocks.v2.yaml @@ -41,7 +41,7 @@ post: - in: header schema: $ref: '../../../beacon-node-oapi.yaml#/components/schemas/ConsensusVersion' - required: false + required: true name: Eth-Consensus-Version description: "Version of the block being submitted, if using SSZ encoding." requestBody: diff --git a/apis/beacon/blocks/blocks.v2.yaml b/apis/beacon/blocks/blocks.v2.yaml index bbb4b48a..ae835348 100644 --- a/apis/beacon/blocks/blocks.v2.yaml +++ b/apis/beacon/blocks/blocks.v2.yaml @@ -39,7 +39,7 @@ post: - in: header schema: $ref: '../../../beacon-node-oapi.yaml#/components/schemas/ConsensusVersion' - required: false + required: true name: Eth-Consensus-Version description: "Version of the block being submitted, if using SSZ encoding." requestBody: From acf5ab70cc78b24b297802bbf40eea8573541aec Mon Sep 17 00:00:00 2001 From: Paul Harris Date: Wed, 5 Jul 2023 19:33:36 +1000 Subject: [PATCH 2/2] updated description --- apis/beacon/blocks/blinded_blocks.v2.yaml | 2 +- apis/beacon/blocks/blocks.v2.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apis/beacon/blocks/blinded_blocks.v2.yaml b/apis/beacon/blocks/blinded_blocks.v2.yaml index ad1e6b3f..ed69b0de 100644 --- a/apis/beacon/blocks/blinded_blocks.v2.yaml +++ b/apis/beacon/blocks/blinded_blocks.v2.yaml @@ -43,7 +43,7 @@ post: $ref: '../../../beacon-node-oapi.yaml#/components/schemas/ConsensusVersion' required: true name: Eth-Consensus-Version - description: "Version of the block being submitted, if using SSZ encoding." + description: "Version of the block being submitted." requestBody: description: "The `SignedBlindedBeaconBlock` object composed of `BlindedBeaconBlock` object (produced by beacon node) and validator signature." required: true diff --git a/apis/beacon/blocks/blocks.v2.yaml b/apis/beacon/blocks/blocks.v2.yaml index ae835348..c3a65980 100644 --- a/apis/beacon/blocks/blocks.v2.yaml +++ b/apis/beacon/blocks/blocks.v2.yaml @@ -41,7 +41,7 @@ post: $ref: '../../../beacon-node-oapi.yaml#/components/schemas/ConsensusVersion' required: true name: Eth-Consensus-Version - description: "Version of the block being submitted, if using SSZ encoding." + description: "Version of the block being submitted." requestBody: description: "The `SignedBeaconBlock` object composed of `BeaconBlock` object (produced by beacon node) and validator signature." required: true