-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Conversation
424f181
to
498802e
Compare
Is it possible to introduce it in both LegacyVM and aleth-interpreter in the same PRs? Or is aleth-interpreter ignored for the non-final-constantinople ones yet? Lastly, would finishing the tracing PR supersede this question? 😉 |
498802e
to
22878d6
Compare
@axic I can try to include aleth-interpreter support here, though I would prefer them to be separate PRs for more manageable PR size, easier review and to merge this earlier. I'm not sure what it has to do with tracing, do you mean we can throw out LegacyVM when tracing is complete? |
I'm fine with that, just was wondering if it is only ignored or will it have its own PR.
Exactly. |
I plan to make another PR for aleth-inerpreter as I did for CREATE2 |
Codecov Report
@@ Coverage Diff @@
## develop #5134 +/- ##
===========================================
+ Coverage 59.63% 59.71% +0.07%
===========================================
Files 337 337
Lines 27184 27247 +63
Branches 3170 3169 -1
===========================================
+ Hits 16212 16270 +58
- Misses 9888 9890 +2
- Partials 1084 1087 +3 |
#5118