Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about circular dependencies #32

Open
Pandapip1 opened this issue Aug 17, 2022 · 5 comments
Open

Warn about circular dependencies #32

Pandapip1 opened this issue Aug 17, 2022 · 5 comments
Labels
ready to implement Feature has reached rough consensus among editors and is ready to be implemented

Comments

@Pandapip1
Copy link
Member

If EIP-X requires EIP-Y, and EIP-Y requires EIP-X, then eipw should give a warning. Same if EIP-X requires EIP-Y requires EIP-Z requires EIP-X, or etc...

@SamWilsn
Copy link
Contributor

This is probably a stupid question, but why?

@Pandapip1
Copy link
Member Author

Pandapip1 commented Aug 17, 2022

One can't move the status of any of them beyond the highest level status of all of them.

@Pandapip1
Copy link
Member Author

If EIP-X is Draft and EIP-Y is also Draft, then neither can move higher due to the other not being stable enough.

If EIP-X is Review and EIP-Y is Draft, EIP-Y can be moved to Review but no higher due to EIP-X not being stable enough.

@SamWilsn
Copy link
Contributor

Sounds like we already have a lint then ;)

Jokes aside, yeah, this is an issue (though I think a minor one?)

Unfortunately it will make eipw slower, or a bit more complicated (i.e. build a graph of EIPs.)

@Pandapip1
Copy link
Member Author

It runs in about 2 seconds anyways. Even if it adds another 2 seconds (worst-case) I'd like it.

@SamWilsn SamWilsn added the ready to implement Feature has reached rough consensus among editors and is ready to be implemented label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to implement Feature has reached rough consensus among editors and is ready to be implemented
Projects
None yet
Development

No branches or pull requests

2 participants