fix transfer invariant, credits to @holiman for finding the edge case #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinDrake
approved these changes
Apr 14, 2019
|
@holiman Yes, thought about it, and asked Justin if allowing self-transfers (but with adjusted rules) would be better. Essentially, the beacon-chain is just a system chain, and the possibility of not having transfers for phase-0 is still up for discussion. Hence the choice for a more straight-forward fix to get the edge-case over with, in a simple way. If we would want beacon transfers for actual more eth1-like functionality, I'm sure we would go for the other more complete solution you mentioned. |
JustinDrake
added a commit
that referenced
this pull request
Apr 14, 2019
Inspired by [this](#916 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See protolambda/zrnt#4