Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

YAML vs 64-bit #17

Open
arnetheduck opened this issue Dec 19, 2018 · 0 comments
Open

YAML vs 64-bit #17

arnetheduck opened this issue Dec 19, 2018 · 0 comments

Comments

@arnetheduck
Copy link

As noted here: ethereum/consensus-specs#224 (comment), keeping serialized tests in YAML format might be problematic for some "standard" yaml parsers, for 64-bit numbers.

Here's a few options to fix this:

  • use strings instead of numbers (adds another decoding step)
  • use a custom YAML parser in affected languages (maybe reasonable, these implementations will need to deal with this problem regardless - looking at you, Javascript/Typescript)
  • use SSZ throughout (not good for some of the testing design goals, like comment support)

refs:

eth2TestGenBot referenced this issue in ethereum/eth2.0-tests Feb 6, 2019
Latest commit message from eth2.0-test-generators:

commit 7157761cef0ef1b4e7df9e04c5bc5d5138d73046
Merge: c7f0df7 1daaeb6
Author: Danny Ryan <[email protected]>
Date:   Wed Feb 6 07:49:14 2019 -0800

    Merge pull request #7 from ethereum/bls

    Move BLS tests from eth2.0-tests repository
@hwwhww hwwhww transferred this issue from ethereum/eth2.0-tests Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants