Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL wrong Event Logs on querying Transactions #25699

Closed
aters opened this issue Sep 6, 2022 · 1 comment
Closed

GraphQL wrong Event Logs on querying Transactions #25699

aters opened this issue Sep 6, 2022 · 1 comment
Labels

Comments

@aters
Copy link

aters commented Sep 6, 2022

System information

Geth version: 1.10.23
OS & Version: Linux
Commit hash : -

Querying block->transactions->logs return event logs for whole block but should return for each transaction. It could be critical for someone who fetching transactions using graphQL and could lead to double-spends. On 1.10.21 node version it is working as expected.

Expected behaviour

When querying for the transactions in block using graphQL we should receive event logs only for the corresponding transactions.

Actual behaviour

We are receiving event logs for ALL transactions in block for EACH transaction.

Steps to reproduce the behaviour

Make a graphQL query to the node:
{ block(number:15484104) { transactions { hash logs { account { address } topics data } } } }

Backtrace

-
@aters aters added the type:bug label Sep 6, 2022
@fjl
Copy link
Contributor

fjl commented Sep 7, 2022

This issue is fixed in #25612, which is already merged to the master branch.

@fjl fjl closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants