Already shutting down, interrupt more to panic #25775
Labels
Comments
|
The shutdown sequence has become stuck here: I.e : // Disconnect existing sessions.
// This also closes the gate for any new registrations on the peer set.
// sessions which are already established but not added to h.peers yet
// will exit when they try to register.
h.peers.close()
h.peerWG.Wait() <-- HEREThe This is where it's been sitting for // dispatchRequest fulfils a pending request and delivers it to the requested
// sink.
func (p *Peer) dispatchResponse(res *Response, metadata func() interface{}) error {
resOp := &response{
res: res,
fail: make(chan error),
}
res.recv = time.Now()
res.Done = make(chan error)
select {
case p.resDispatch <- resOp:
// Ensure the response is accepted by the dispatcher
if err := <-resOp.fail; err != nil {
return nil
}
// Request was accepted, run any postprocessing step to generate metadata
// on the receiver thread, not the sink thread
if metadata != nil {
res.Meta = metadata()
}
// Deliver the filled out response and wait until it's handled. This
// path is a bit funky as Go's select has no order, so if a response
// arrives to an already cancelled request, there's a 50-50% changes
// of picking on channel or the other. To avoid such cases delivering
// the packet upstream, check for cancellation first and only after
// block on delivery.
select {
case <-res.Req.cancel:
return nil // Request cancelled, silently discard response
default:
// Request not yet cancelled, attempt to deliver it, but do watch
// for fresh cancellations too
select { <--- STUCK ON THIS LINE
case res.Req.sink <- res:
return <-res.Done // Response delivered, return any errors
case <-res.Req.cancel:
return nil // Request cancelled, silently discard response
}
} |
|
I think this should fix it diff --git a/eth/protocols/eth/dispatcher.go b/eth/protocols/eth/dispatcher.go
index 65a935d555..1486a70022 100644
--- a/eth/protocols/eth/dispatcher.go
+++ b/eth/protocols/eth/dispatcher.go
@@ -174,6 +174,8 @@ func (p *Peer) dispatchResponse(res *Response, metadata func() interface{}) erro
return <-res.Done // Response delivered, return any errors
case <-res.Req.cancel:
return nil // Request cancelled, silently discard response
+ case <-p.term:
+ return errDisconnected
}
}That should fix the shutdown problem, but there's some other underlying error here which also needs to be fixed, namely -- why doesn't that request become cancelled earlier? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Geth version: 1.10.25
OS & Version: Windows 10
Expected behaviour
Almost every version of get lately gives me this problem, after hitting ctrl+c it just won't stop, some times I wait half an hour and nothing
Actual behaviour
It gives me "Already shutting down, interrupt more to panic" and when i interrupt it more I get this:
https://pastebin.com/HpWBRxMp
Steps to reproduce the behaviour
Try to stop geth on Windows 10 with ctrl+c
The text was updated successfully, but these errors were encountered: