Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add testcase for txpool #14673

Merged
merged 2 commits into from
Jun 22, 2017
Merged

core: add testcase for txpool #14673

merged 2 commits into from
Jun 22, 2017

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jun 22, 2017

There are cases where transactions remain in pool.all , despite not being either pending or queued. This PR contains a testcase to reproduce such an occurrence.

#go test . -run TestTransactionCapClearsFromAll
--- FAIL: TestTransactionCapClearsFromAll (0.01s)
	tx_pool_test.go:896: Pending 8, Queued: 0, but pool.all = 16, expected 8
FAIL
FAIL	github.com/ethereum/go-ethereum/core	0.172s

Related to #14669

@holiman
Copy link
Contributor Author

holiman commented Jun 22, 2017

Added the same test to more places:

#go test . -run .
--- FAIL: TestTransactionPendingGlobalLimiting (0.30s)
	tx_pool_test.go:779: Pool.all size 320 != 160 pending + 0 queued
--- FAIL: TestTransactionCapClearsFromAll (0.01s)
	tx_pool_test.go:822: Pool.all size 16 != 8 pending + 0 queued
--- FAIL: TestTransactionPendingMinimumAllowance (0.02s)
	tx_pool_test.go:864: Pool.all size 20 != 10 pending + 0 queued
--- FAIL: TestTransactionPoolRepricing (0.01s)
	tx_pool_test.go:921: queued transactions mismatched: have 2, want 3
FAIL
FAIL	github.com/ethereum/go-ethereum/core	9.391s

@holiman holiman requested a review from karalabe June 22, 2017 08:58
@karalabe karalabe added this to the 1.6.6 milestone Jun 22, 2017
@karalabe karalabe merged commit b664bed into ethereum:master Jun 22, 2017
@holiman holiman deleted the txfix branch June 23, 2017 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants