core: kill off managed state, use own tiny noncer for txpool #19810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 10, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some ancient legacy code called
state.ManagedStatethat was supposed to be a "virtual, in-memory" clone of astate.StateDBfor the transaction pool. This managed state had a lot of weird unused code (probably originally it was meant to be something else). The only thing the txpool needed was to set and get nonces.Not only did
state.ManagedStatehave more code than needed, it also directly calledSetNonceon the underlying state database, which triggered the state journal. With the correct circumstances, this resulted in memory overhead that could lead to a crash if no chain head arrived fast enough.This PR murders the managed state altogether, and replaces it with a tiny, simple construct with only the things we need for the txpool.