ethclient: serialize negative block number as "pending" #21177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
changed the title
| @@ -44,11 +44,11 @@ type Log struct { | |||
| // hash of the transaction | |||
| TxHash common.Hash `json:"transactionHash" gencodec:"required"` | |||
| // index of the transaction in the block | |||
| TxIndex uint `json:"transactionIndex" gencodec:"required"` | |||
There was a problem hiding this comment.
Any particular reason to drop this restriction?
There was a problem hiding this comment.
No block = no tx index.
rjl493456442
approved these changes
Jun 23, 2020
fjl
reviewed
Jun 26, 2020
ethclient/ethclient.go
Outdated
| @@ -282,6 +282,9 @@ func toBlockNumArg(number *big.Int) string { | |||
| if number == nil { | |||
| return "latest" | |||
| } | |||
| if number.Sign() < 0 { | |||
There was a problem hiding this comment.
I think we should be a bit more strict here and only allow -1 to mean pending.
That way, we can use other negative numbers for different things later.
10 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
Fixes ethereum#21175 Co-authored-by: sammy007 <[email protected]> Co-authored-by: Adam Schmideg <[email protected]>
19 tasks
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21175