Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: deprecate Client.ShhSubscribe #22239

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Conversation

gballet
Copy link
Member

@gballet gballet commented Jan 26, 2021

It never worked, whisper uses polling.

@gballet gballet requested review from fjl and holiman as code owners January 26, 2021 09:26
@fjl
Copy link
Contributor

fjl commented Jan 26, 2021

We can't remove this method because it has been around for quite a while and I don't want to break the API.
However, we can mark it deprecated. To do this, add a comment like

// ShhSubscribe registers a subscripion under the "shh" namespace.
// Deprecated: use Subscribe(ctx, "shh", ...) instead.

@gballet
Copy link
Member Author

gballet commented Jan 26, 2021

@fjl it's not going to break anything, this function never worked: whisper didn't use the subscription api.

@fjl
Copy link
Contributor

fjl commented Jan 27, 2021

This method is used in package shhclient: https://github.com/ethereum/whisper/blob/master/shhclient/client.go#L171

@gballet
Copy link
Member Author

gballet commented Jan 27, 2021

and yet, it never worked

@gballet gballet changed the title rpc: Remove whisper subscription rpc: Deprecate whisper subscription Jan 27, 2021
@fjl fjl changed the title rpc: Deprecate whisper subscription rpc: deprecate Client.ShhSubscribe Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants