go.mod : goleveldb Reduce memory allocation #23417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
LGTM
Replacing the weird bufferpool with a sync.Pool was something that I also took a stab at some time ago. This could significantly decrease mem allocs.
Updating Snappy to 0.0.4 is also a good change (we didn't update yet because there's no real difference between 0.0.3 and 0.0.4 only testing updates and more inclusive language)
|
Thanks - this looks good and will most likely be merged - we just need to run it to see the actual improvements - or did you do some benchmarks by any chance? |
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 25, 2021
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Nov 29, 2021
Co-authored-by: ucwong <[email protected]>
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Jan 31, 2022
Co-authored-by: ucwong <[email protected]>
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce memory allocation of buffer_pool and db
syndtr/goleveldb#367
snappy-4.0.0 upgrade
syndtr/goleveldb#365