Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints #8

Open
jannikluhn opened this issue Dec 7, 2018 · 6 comments
Open

Add type hints #8

jannikluhn opened this issue Dec 7, 2018 · 6 comments

Comments

@jannikluhn
Copy link
Contributor

We should add type hints and check them in CI.

@Bhargavasomu
Copy link
Contributor

I will take this up once #17 is merged.

@jannikluhn
Copy link
Contributor Author

@Bhargavasomu Note that most of this should be done already in #22.

@hwwhww
Copy link
Contributor

hwwhww commented Jan 17, 2019

@Bhargavasomu would you like to take it + enable mypy in tox?

@Bhargavasomu
Copy link
Contributor

@hwwhww I will take this up.

@jannikluhn
Copy link
Contributor Author

There's not a lot of documentation and it's unstable, but if we want to have type hints for Serializable.__init__ (which I think we should), we probably have to write a mypy plugin.

@pacrob
Copy link
Contributor

pacrob commented Dec 4, 2023

There are a lot of types throughout the lib, but it doesn't appear that mypy checks were ever run as part of CI. With the incoming template updates, mypy is being added as part of the pre-commit checks, but with the ssz folder excluded. As files are typed, they can be added to be checked. See pre-commit docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants