Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string eth_sendRawTransaction(string _trRLPWithSig) #6

Closed
winsvega opened this issue Feb 27, 2018 · 12 comments
Closed

string eth_sendRawTransaction(string _trRLPWithSig) #6

winsvega opened this issue Feb 27, 2018 · 12 comments

Comments

@winsvega
Copy link
Collaborator

winsvega commented Feb 27, 2018

string eth_sendRawTransaction(string _transactionRLP)

Accepts a transaction RLP list of the following items:

u256 nonce;
u256 gasPrice;
u256 gasLimit;
hash32 toAddress (could be empty)
u256 value
bytes data;
byte v  (in form 27 + (0|1)  and so on)
h256 r 
h256 s

and apply on top of the current chain configuration. (add it to a block which is yet not finalized)
returns the hash of the imported transaction if transaction is valid. or 0 if it's not.

@winsvega winsvega changed the title test_addTransaction string test_addTransaction(string _jsonTransaction) Feb 28, 2018
@winsvega
Copy link
Collaborator Author

winsvega commented Mar 29, 2018

rename to test_signAndSendTransaction by proposal of @gumb0?

@pirapira
Copy link
Member

test_signAndAppendTransaction?

@chfast
Copy link
Member

chfast commented Mar 29, 2018

secretKey -> privateKey?

@winsvega
Copy link
Collaborator Author

winsvega commented Mar 29, 2018

test files has this field named "secretKey". that might be confusing but doable

@chfast
Copy link
Member

chfast commented Mar 29, 2018

The "secret key" is confusing by itself. Nobody knows what it is except ~5 people.

@cdetrio
Copy link
Member

cdetrio commented Mar 29, 2018

Why not sign the tx in the test runner and then send it to the client with eth_sendRawTransaction? Fewer RPC methods makes it easier to support more clients.

@winsvega
Copy link
Collaborator Author

winsvega commented Mar 29, 2018

that would require test runner to implement crypto libs, making it heavier

@pirapira
Copy link
Member

@winsvega why? There is signTransaction RPC method.

@winsvega
Copy link
Collaborator Author

winsvega commented Mar 29, 2018

ok. then I should study how it works. so maybe there is no need in this method.
I see, I've remembered.
@pirapira is there a method to add account by private key via RPC ? signTransaction wont work if there is no account

@winsvega
Copy link
Collaborator Author

winsvega commented Apr 4, 2018

@pirapira @cdetrio @holiman
ok. what if instead of adding this new method. there would be a
test_registerAccount(Privatekey)

then it would be possible to use existing signTransaction and sendRawTransaction

@winsvega winsvega changed the title string test_addTransaction(string _jsonTransaction) string eth_sendRawTransaction(string _trRLPWithSig) Apr 9, 2018
@winsvega
Copy link
Collaborator Author

winsvega commented Apr 9, 2018

replacing this requirement with standart eth_sendRawTransaction

@winsvega
Copy link
Collaborator Author

winsvega commented Sep 1, 2019

@winsvega winsvega closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants