-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: bump address range used in tests #1371
Comments
so you even recalculated create addresses in some of thests expect sections? |
@winsvega yes, I recalculated CREATE and CREATE2 addresses for some of these tests. I setup retesteth by building the Dockerfile in a Linux machine, which I used to refill the tests |
There is also dretesteth.sh script for docker. Wow, you are one of the few who went through this process so smoothly |
Not very smooth 😆 it took me a first, failed try to run it locally on MacOS for ~half a day, then I gave up and SSHed into a EC2 instance running linux, tried to use the docker image specified in the docs but somehow I could not get it to work, eventually I managed to get it to work but it took like 1.5 days 😅 Also, for CREATE/CREATE2 addresses, I don't know if there's a specific way to compute them and add them in tests, so I was manually fixing them one by one,after each test run |
should have contact me for support. the docker image must work smoothly ./dretesteth.sh build. the create/create2 addresses issue we fixed in .py tests. |
In many test cases, we use addresses such as 0x100, 0x101, etc.
However, new improvement proposals aimed specifically for rollups (RIPs) are starting to introduce new precompiles, such as RIP-7212. These precompiles will use addresses starting from 0x100.
As such, it would be good to refactor the existing tests, and modify the addresses close to 0x100 to something else, like 0x1000.
The text was updated successfully, but these errors were encountered: