Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Offer message type to use ContentKey type #231

Closed
njgheorghita opened this issue Jan 24, 2022 · 3 comments
Closed

Update Offer message type to use ContentKey type #231

njgheorghita opened this issue Jan 24, 2022 · 3 comments

Comments

@njgheorghita
Copy link
Collaborator

More of a placeholder so I don't lose track of this, but anybody can feel free to pick this one up.
@Narasimha1997
Copy link

Narasimha1997 commented Jan 30, 2022 •
edited
Loading

@njgheorghita
Can you please explain this? I would like to work on this.

@njgheorghita
Copy link
Collaborator Author

Hey 👋 - Basically, we need to update the Offer message type here to use our custom ContentKey type here for its content_keys field instead of Vec<Vec<u8>>

So, the Offer type should look like ..

#[derive(Debug, PartialEq, Clone, Encode, Decode)]
pub struct Offer {
    pub content_keys: Vec<ContentKey>,
}

@KolbyML
Copy link
Member

KolbyML commented Apr 13, 2023

Solved with this PR #325

@KolbyML KolbyML closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@njgheorghita @Narasimha1997 @KolbyML