Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Constantinople] EIP 1234 Difficulty bomb delay and block reward adjustment #355

Closed
holgerd77 opened this issue Sep 24, 2018 · 3 comments
Closed

Comments

@holgerd77
Copy link
Member

holgerd77 commented Sep 24, 2018

EIP 1234 Constantinople difficulty bomb delay and block reward adjustment.

Depends on ethereumjs/ethereumjs-block#53.

@holgerd77
Copy link
Member Author

Hi @alextsg, just had a short look and would assume that the code in the VM regarding the miner reward doesn't need to be changed, didn't put much thought into it though.

Did you have a somewhat closer/deeper look and would you confirm that?

@alextsg
Copy link
Contributor

alextsg commented Oct 23, 2018

@holgerd77 I referenced the implementation of EIP-649 (Metropolis Difficulty Bomb Delay and Block Reward Reduction) and saw that only the ethereumjs-block and ethereumjs-common libraries were updated so I assumed the same.

@holgerd77
Copy link
Member Author

Difficulty bomb delay addressed in ethereumjs/ethereumjs-block#54, block reward adjustment implicitly handled through updated ethereumjs-common miner reward adjustment (self._common.param('pow', 'minerReward') in runBlock()), will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants